Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE: Impl ACL endpoints for consumer, producer, stream apps #3783

Merged
merged 6 commits into from
Aug 1, 2023
Merged

BE: Impl ACL endpoints for consumer, producer, stream apps #3783

merged 6 commits into from
Aug 1, 2023

Conversation

iliax
Copy link
Contributor

@iliax iliax commented May 5, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

ACL Endpoint for consumer, producer, stream app added

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@iliax iliax requested a review from a team as a code owner May 5, 2023 06:15
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label May 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@iliax iliax linked an issue May 24, 2023 that may be closed by this pull request
BE: ACL management #124
Open
iliax added 2 commits June 21, 2023 14:27
Merge branch 'master' of github.com:provectus/kafka-ui into acl_speci…
974bd29 
…fic_endpoints

� Conflicts:
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/acl/AclsService.java
merged with utd master
ae13d60
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature scope/backend and removed status/triage Issues pending maintainers triage labels Aug 1, 2023
@Haarolean Haarolean changed the title ACL Endpoint for consumer, producer, stream app BE: Impl ACL endpoints for consumer, producer, stream apps Aug 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Haarolean Haarolean merged commit 1cd303a into master Aug 1, 2023
9 checks passed
@Haarolean Haarolean deleted the acl_specific_endpoints branch August 1, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haarolean Haarolean Haarolean approved these changes

Assignees
No one assigned
Labels
scope/backend type/enhancement En enhancement to an already existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BE: ACL management
2 participants
@iliax @Haarolean