Update Money protobuf validation to use string value #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpatel-figure
added
patch
Test Results 12 files ±0 12 suites ±0 3m 13s ⏱️ +29s Results for commit 933173d. ± Comparison against base commit bf16778. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov Report
@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 73.38% 73.70% +0.31%
==========================================
Files 16 16
Lines 496 502 +6
Branches 119 120 +1
==========================================
+ Hits 364 370 +6
Misses 81 81
Partials 51 51
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rpatel-figure
force-pushed
the
ravipatel/update-to-string-money-value
branch
from
b907382
to
c292e3b
Compare
rpatel-figure
force-pushed
the
ravipatel/update-to-string-money-value
branch
from
c292e3b
to
933173d
Compare
| internal fun ContractEnforcementContext.moneyValidation(parentDescription: String = "Input's money", money: FigureTechMoney?) { | ||
| money.takeIf { it.isSet() }?.let { setMoney -> | ||
| requireThat( | ||
| setMoney.value.matches(Regex("^[-]?([0-9]+(?:[\\\\.][0-9]+)?|\\\\.[0-9]+)\$")) orError "$parentDescription must have a valid value", |
There was a problem hiding this comment.
just curious: are values less than $1 supposed to come in as 0.15 or .15? In the latter case, the decimal wouldn't be picked up by this expression
There was a problem hiding this comment.
The former, with a leading 0. It just seems to be the choice made 🤷🏽
cworsnop-figure
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Updating the contracts to the latest version of metadata-asset-model per the changes made in provenance-io/metadata-asset-model#15
Changes
Patch
metadata-asset-modelfrom0.1.11to0.1.12tech.figure.util.v1beta1.Moneyvalidation to validate the new string field over the deprecated double fieldNotes
ServicingDatarecord. However, the loan scope and its contracts are still in beta and being influenced by initial use cases, soServicingData.originalNoteAmountdoes not undergo any validation as of this version.