Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from buildSrc to Gradle catalog for dependencies #52

Merged

Conversation

rpatel-figure
Copy link
Collaborator

@rpatel-figure rpatel-figure commented Jan 31, 2023

Context

Switching from using custom objects and classes defined in buildSrc to using a Gradle version catalog for compatibility with Renovate

Changes

  • Remove buildSrc Dependencies.kt file
  • Add Gradle versions catalog
  • Add self as developer for publishing metadata
  • Update Gradle from 7.4.2 to 7.6

@rpatel-figure rpatel-figure added patch Bug fixes or other non-breaking configuration changes dependencies An update to project dependencies chore labels Jan 31, 2023
@github-actions
Copy link

github-actions bot commented Jan 31, 2023

Test Results

  12 files  ±0    12 suites  ±0   5m 36s ⏱️ + 1m 24s
  51 tests ±0    45 ✔️ ±0    6 💤 ±0  0 ±0 
127 runs  ±0  116 ✔️ ±0  11 💤 ±0  0 ±0 

Results for commit b337743. ± Comparison against base commit a48f160.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Base: 74.44% // Head: 74.44% // No change to project coverage 👍

Coverage data is based on head (a64dd62) compared to base (a48f160).
Patch has no changes to coverable lines.

❗ Current head a64dd62 differs from pull request most recent head b337743. Consider uploading reports for the commit b337743 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   74.44%   74.44%           
=======================================
  Files          16       16           
  Lines         536      536           
  Branches      129      129           
=======================================
  Hits          399      399           
  Misses         79       79           
  Partials       58       58           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@cworsnop-figure cworsnop-figure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpatel-figure rpatel-figure merged commit 9d987ad into main Feb 1, 2023
@rpatel-figure rpatel-figure deleted the ravipatel/switch-from-buildSrc-to-gradle-catalog branch February 1, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies An update to project dependencies patch Bug fixes or other non-breaking configuration changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants