PW-1933 Fix backward compatibility issue on DateTime fields (With fix and Javadoc) #122
Conversation
…ized from XMLGregorianCalendar objects
|
Warning Rate limit exceeded@fernando-prowide has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 21 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughWalkthroughThe recent changes enhance the JSON deserialization capabilities of the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant OffsetDateTimeJsonAdapter
participant JSONParser
participant XMLGregorianCalendarDTO
Client->>OffsetDateTimeJsonAdapter: Request deserialization
OffsetDateTimeJsonAdapter->>JSONParser: Attempt to parse DateTimeOffsetDTO
JSONParser-->>OffsetDateTimeJsonAdapter: Return parsed object or error
alt Parsing successful
OffsetDateTimeJsonAdapter-->>Client: Return deserialized OffsetDateTime
else Parsing failed
OffsetDateTimeJsonAdapter->>XMLGregorianCalendarDTO: Attempt to parse XMLGregorianCalendarDTO
XMLGregorianCalendarDTO-->>OffsetDateTimeJsonAdapter: Return parsed object
OffsetDateTimeJsonAdapter-->>Client: Return deserialized OffsetDateTime
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
...ore/src/test/java/com/prowidesoftware/swift/model/mx/adapters/OffsetTimeJsonAdapterTest.java
Outdated
Show resolved
Hide resolved
zubri
changed the title
Issue 118: Fix backward compatibility issue on DateTime fields seriaized from XMLGregorianCalendar objects
To be able to continue to parse JSON files generated from 9.x libraries using
AbstractMX.toJson()when migrating to 10.x by doing anAbstractMX.fromJson(), which is a blocker for applications that were created before the existence of the 10.x branch and wouldn't be able anymore to read their previous files.Another possibility could be to expose a public version of the
fromJsonmethod accepting custom adapters if you don't want to maintain the compatibility.Summary by CodeRabbit
New Features
OffsetDateTimeto support multiple DTO formats, improving flexibility and compatibility.Bug Fixes