Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve check28 #181

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Improve check28 #181

merged 1 commit into from
Feb 22, 2018

Conversation

doshitan
Copy link
Contributor

The CIS benchmarks state that only customer managed CMKs should be checked, so
exclude all AWS managed CMKs, not just the one for ACM.

Also fix up some formatting and dead code.

@doshitan
Improve check28
d7f4f99 
The CIS benchmarks state that only customer managed CMKs should be checked, so
exclude all AWS managed CMKs, not just the one for ACM.

Also fix up some formatting and dead code.
toniblyx
toniblyx approved these changes Feb 22, 2018
View reviewed changes
Copy link
Member

@toniblyx toniblyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @doshitan, this is a very good one. I don't remember now but they may have changed the API response since I wrote this check.

@toniblyx toniblyx merged commit fa03991 into prowler-cloud:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toniblyx toniblyx toniblyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doshitan @toniblyx