feat(gcp): add CIS checks #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergargar
force-pushed
the
PRWLR-2331-complete-gcp-cis
branch
from
d3cccd5
to
2b2ef33
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # Get Log Sink Buckets | ||
| log_buckets = [] | ||
| for sink in logging_client.sinks: | ||
| if "storage.googleapis.com" in sink.destination: |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization
sergargar
force-pushed
the
PRWLR-2331-complete-gcp-cis
branch
from
50b7ca5
to
2a311a3
Compare
toniblyx
previously requested changes
Jul 6, 2023
n4ch04
reviewed
Jul 6, 2023
README.md
Outdated
| @@ -40,7 +40,7 @@ It contains hundreds of controls covering CIS, NIST 800, NIST CSF, CISA, RBI, Fe | |||
| | Provider | Checks | Services | [Compliance Frameworks](https://docs.prowler.cloud/en/latest/tutorials/compliance/) | [Categories](https://docs.prowler.cloud/en/latest/tutorials/misc/#categories) | | |||
| |---|---|---|---|---| | |||
| | AWS | 283 | 55 -> `prowler aws --list-services` | 21 -> `prowler aws --list-compliance` | 5 -> `prowler aws --list-categories` | | |||
| | GCP | 59 | 10 -> `prowler gcp --list-services` | CIS soon | 0 -> `prowler gcp --list-categories`| | |||
| | GCP | 73 | 11 -> `prowler gcp --list-services` | 1 -> `prowler aws --list-compliance` | 0 -> `prowler gcp --list-categories`| | |||
There was a problem hiding this comment.
Suggested change
| | GCP | 73 | 11 -> `prowler gcp --list-services` | 1 -> `prowler aws --list-compliance` | 0 -> `prowler gcp --list-categories`| | |
| | GCP | 73 | 11 -> `prowler gcp --list-services` | 1 -> `prowler gcp --list-compliance` | 0 -> `prowler gcp --list-categories`| |
n4ch04
reviewed
Jul 6, 2023
prowler/config/config.py
Outdated
Comment on lines
38
to
45
| with os.scandir(compliance_gcp_dir) as files: | ||
| files = [ | ||
| file.name | ||
| for file in files | ||
| if file.is_file() | ||
| and file.name.endswith(".json") | ||
| and available_compliance_frameworks.append(file.name.removesuffix(".json")) | ||
| ] |
There was a problem hiding this comment.
Could you please reutilise the above code to iterate through the compliance directories?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add 14 GCP checks to complete CIS.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.