-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(unused services): scan unused services by default and add flag #3556
Conversation
You can check the documentation for this PR here -> SaaS Documentation |
You can check the documentation for this PR here -> SaaS Documentation |
You can check the documentation for this PR here -> SaaS Documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Great change to rename this variable, now it easier to read and to understand 👏
You can check the documentation for this PR here -> SaaS Documentation |
You can check the documentation for this PR here -> SaaS Documentation |
You can check the documentation for this PR here -> SaaS Documentation |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## prowler-4.0-dev #3556 +/- ##
===================================================
- Coverage 86.15% 86.15% -0.01%
===================================================
Files 684 684
Lines 21139 21139
===================================================
- Hits 18213 18212 -1
- Misses 2926 2927 +1 ☔ View full report in Codecov by Sentry. |
You can check the documentation for this PR here -> SaaS Documentation |
You can check the documentation for this PR here -> SaaS Documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩
Description
Scan unused services by default and add flag
--scan-unused-services
in case the user wants to scan it.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.