Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(unused services): scan unused services by default and add flag #3556

Merged
merged 8 commits into from
Mar 19, 2024

Conversation

sergargar
Copy link
Member

Description

Scan unused services by default and add flag --scan-unused-services in case the user wants to scan it.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergargar sergargar requested a review from a team March 18, 2024 10:18
@github-actions github-actions bot added documentation provider/aws Issues/PRs related with the AWS provider labels Mar 18, 2024
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

jfagoagas
jfagoagas previously approved these changes Mar 19, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great change to rename this variable, now it easier to read and to understand 👏

docs/tutorials/scan-unused-services.md Outdated Show resolved Hide resolved
@jfagoagas jfagoagas self-requested a review March 19, 2024 09:16
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

jfagoagas
jfagoagas previously approved these changes Mar 19, 2024
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.15%. Comparing base (ab81512) to head (a31163a).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           prowler-4.0-dev    #3556      +/-   ##
===================================================
- Coverage            86.15%   86.15%   -0.01%     
===================================================
  Files                  684      684              
  Lines                21139    21139              
===================================================
- Hits                 18213    18212       -1     
- Misses                2926     2927       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@jfagoagas jfagoagas merged commit 35043c2 into prowler-4.0-dev Mar 19, 2024
12 checks passed
@jfagoagas jfagoagas deleted the ignore-unused-services-by-default branch March 19, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants