Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opensearch): handle non existing SAMLOptions in domain #4086

Merged

Conversation

MrCloudSec
Copy link
Member

Description

Handle non existing SAMLOptions in OpenSearch Domain.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team May 24, 2024 16:33
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.31%. Comparing base (ee178c2) to head (d6f2ab0).
Report is 450 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4086      +/-   ##
==========================================
- Coverage   86.39%   86.31%   -0.09%     
==========================================
  Files         790      790              
  Lines       24729    24729              
==========================================
- Hits        21364    21344      -20     
- Misses       3365     3385      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add get() for all the calls in the function? Thanks!

@MrCloudSec
Copy link
Member Author

Could you please add get() for all the calls in the function? Thanks!

At which calls do you refer? Remember that we have to do this one by one because since we have to make sure to handle each specific case correctly.

@jfagoagas jfagoagas self-requested a review May 27, 2024 14:03
@jfagoagas
Copy link
Member

Could you please add get() for all the calls in the function? Thanks!

At which calls do you refer? Remember that we have to do this one by one because since we have to make sure to handle each specific case correctly.

I meant for all the calls within that function but it's good for now.

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@jfagoagas jfagoagas merged commit 9c8280d into master May 27, 2024
10 of 11 checks passed
@jfagoagas jfagoagas deleted the PRWLR-3787-solve-sentry-issue-key-error-120-saml-options branch May 27, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants