-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(opensearch): handle non existing SAMLOptions in domain #4086
fix(opensearch): handle non existing SAMLOptions in domain #4086
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4086 +/- ##
==========================================
- Coverage 86.39% 86.31% -0.09%
==========================================
Files 790 790
Lines 24729 24729
==========================================
- Hits 21364 21344 -20
- Misses 3365 3385 +20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add get()
for all the calls in the function? Thanks!
At which calls do you refer? Remember that we have to do this one by one because since we have to make sure to handle each specific case correctly. |
I meant for all the calls within that function but it's good for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔝
Description
Handle non existing
SAMLOptions
in OpenSearch Domain.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.