Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close() to DataTransformer #60

Merged
merged 1 commit into from
May 31, 2024
Merged

Add close() to DataTransformer #60

merged 1 commit into from
May 31, 2024

Conversation

gpauloski
Copy link
Contributor

Description

Add close() to DataTransformer.

Also fixed enum error in some configs.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (internal implementation changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (no changes to the code)
  • CI change (changes to CI workflows, packages, templates, etc.)
  • Version changes (changes to the package or dependency versions)

Testing

N/A

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Relevant tags are added (breaking, bug, dependencies, documentation, enhancement, refactor).
  • Code changes pass pre-commit (e.g., ruff, mypy, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

Also fixed enum error in some configs
@gpauloski gpauloski added the enhancement New features or improvements to existing functionality label May 31, 2024
@gpauloski gpauloski merged commit cb3bd2d into main May 31, 2024
7 checks passed
@gpauloski gpauloski deleted the issue-42 branch May 31, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or improvements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data transformers have no close mechanism
1 participant