Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Meilisearch version and docker files #13

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Update Meilisearch version and docker files #13

merged 3 commits into from
Apr 18, 2023

Conversation

prrao87
Copy link
Owner

@prrao87 prrao87 commented Apr 18, 2023

Updates

  • Bugfix: Mentioning the minor version of Meilisearch is important, as the docker resolver looks for this when starting the DB
    • Specifying the version as v1.1.1 works as intended
  • Improve comments and verify that timing performance results from Improve indexing performance #12 worked as intended
    • The same workflow when working with aiofiles to asynchronously read from files does not perform as well
    • Applying Pydantic validation line-by-line on the JSONL files is slower (expectedly so) than applying Pydantic validation to the entire file's contents as once via a list comprehension.

For now, this seems like the best performance that we can get with Meilisearch!

@prrao87 prrao87 merged commit 1b23cd6 into main Apr 18, 2023
@prrao87 prrao87 deleted the meilisearch branch April 18, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant