fix pio build #2183
Closed
fix pio build #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bgiot Are all thesw formatting changes necessary? It will break any lcd related PRs that are not merged yet and are planned for 3.9. Did you try #2181? I find these PRs simmilar, except the fact that mine also fixes some warnings and yours fixes formatting. I’d prefer if formatting was fixed last, functionality being a priority. @DRracer do you agree? |
|
Sorry, formatting done automatically by editor... |
|
As far as i can tell, the only change is in function lcd_putchar. Instead of being declared as void it's now int. |
|
A fix has been merged. You can close this PR now. |
|
@leptun you are so fast, I was about to write the same ;) |
|
@bgiot anyway, thanks for reporting and giving a PR ;) |
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix UI issue when building firmware 3.8.0 with pio