feat: add default alertmanagers to silence form #5086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That will allow setting some default alertmanagers to select when creating a new silence, overriding the current behavior of getting all the ones that are not readonly. Signed-off-by: David Caro <dcaro@wikimedia.org>
david-caro
force-pushed
the
add_default_alertmanagers_to_silence_form
branch
from
6685890
to
d726d6b
Compare
david-caro
changed the title
prymitive
approved these changes
Mar 8, 2023
|
Thanks! |
|
That was fast and pleasant! Thanks a lot! (+100 for adding the tests xd, I'm not very well versed in typescript/react) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows setting some default alertmanagers to select when
creating a new alert, overriding the current behavior of getting all
the ones that are not readonly.
This pull request adds a new configuration value under
silenceForm.defaultAlertmanagersthat allows specifying the names of the alertmanagers that will be set by default in the form to create a new silence.For HA clusters of alertmanagers, if any of the members matches the name the whole cluster will be selected.
If it's not set, the behavior does not change.
The case for this came from adding two alertmanagers to our karma instance, but one of them being "specialized" and not really meant for most users to use. And to avoid users creating silences on that one by default, we thought of this change, that will prevent "doing the wrong thing" unless you really want to.