update broken links in linux and mac install pages fix #83 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
prestonvanloon
approved these changes
May 8, 2020
|
a few links in this PR are still broken |
wgknowles
reviewed
May 10, 2020
| @@ -95,7 +95,7 @@ This page serves material necessary to catch up with the current state of ETH2 d | |||
|
|
|||
| ## Ethereum client implementations | |||
|
|
|||
| * [Geth](https://github.com/ethereum/go-ethereum) \(known also as go-ethereum\) is the Golang implementation of [ETH1](../glossaries/terminology.md#eth1) | |||
| * [Geth](https://github.com/ethereum/go-ethereum) \(known also as go-ethereum\) is the Golang implementation of [ETH1](/docs/glossaries/terminology#eth1) | |||
There was a problem hiding this comment.
yep. I was just flagging a few issues I came across reading the docs. Didn't intend for a comprehensive update :-) So.. I'm new at this ... should I close this PR or leave it open for other updates?
There was a problem hiding this comment.
I didn't mean to double-up on the work. I should have checked for existing PR's before i started. Your work is much appreciated! I see you caught some bad anchors that I missed, need to make sure those get in.
|
Resolved by #97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed broken links. by adding absolute paths - noted previous comment suggesting not to use relative paths. First time using git/github/docker for contribution :-)