Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Sharding Management Contract to Align With New Phase 1 #64

Closed
3 tasks
terencechain opened this issue Mar 7, 2018 · 6 comments
Closed
3 tasks
Assignees
Labels
Help Wanted Extra attention is needed
Milestone

Comments

@terencechain
Copy link
Member

terencechain commented Mar 7, 2018

SMC needs to make the following modifications for Proposer

  • add Proposer struct and mapping (similar to the Validator's stack implementation)
  • functions to deposit and withdraw
  • functions to verify Proposer's signature, deduct Proposer's bid from deposit upon receiving collation header

Let me know if I miss anything

@rauljordan rauljordan changed the title Add Proposer to Validator Management Contract Add Proposer to Sharding Management Contract Mar 8, 2018
@rauljordan rauljordan added the Help Wanted Extra attention is needed label Mar 8, 2018
@rauljordan rauljordan added this to the Ruby milestone Mar 8, 2018
@rauljordan rauljordan changed the title Add Proposer to Sharding Management Contract Modify Sharding Management Contract to Align With New Phase 1 Mar 21, 2018
@rauljordan
Copy link
Contributor

rauljordan commented Mar 21, 2018

Phase 1 New Spec SMC Changes
We will be including the methods from the SMC phase 1 spec. I believe @enriquefynn is working on this.

@prestonvanloon
Copy link
Member

@enriquefynn can you update this issue? The requirements that @terenc3t outlined are not accurate.

@terencechain
Copy link
Member Author

Sorry, we do need to update this issue. Those requirements were before phase 1 spec

@enriquefynn
Copy link
Contributor

enriquefynn commented Mar 21, 2018

I'll make a PR when I have a more or less functioning implementation from the spec @rauljordan referenced. Basically what we need is in the spec, doesn't make much sense to replicate it here.

@prestonvanloon
Copy link
Member

There are some new requirements for SMC, see #89

@rauljordan
Copy link
Contributor

Closing this for now for neatness purposes. We'll continue in #89.

Redidacove pushed a commit to Redidacove/prysm that referenced this issue Aug 13, 2024
* Update development-updates.md

Week 1 Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants