Change Hashing Function from Blake2b to Sha3 #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1045 +/- ##
=======================================
Coverage 72.08% 72.08%
=======================================
Files 75 75
Lines 4579 4579
=======================================
Hits 3301 3301
Misses 961 961
Partials 317 317 |
nisdas
reviewed
Dec 5, 2018
| @@ -27,7 +27,7 @@ func TestRunShuffleTest(t *testing.T) { | |||
| } | |||
| testCase := &ShuffleTestCase{ | |||
| Input: []uint32{1, 2, 3, 4, 5}, | |||
| Output: []uint32{2, 4, 1, 3, 5}, | |||
| Output: []uint32{2, 4, 5, 1, 3}, | |||
There was a problem hiding this comment.
Shuffle test uses the hashing function. Diff hashing algorithm produces different shuffled output...
| // https://github.com/ethereum/eth2.0-specs/blob/master/specs/core/0_beacon-chain.md#appendix | ||
| func Hash(data []byte) [32]byte { | ||
| var hash [32]byte | ||
| h := blake2b.Sum512(data) | ||
|
|
||
| h := sha3.Sum256(data) |
There was a problem hiding this comment.
which sha3 is this ? the keccak-256 used by ethereum is different then what is finalised as sha3 as a standard
For reference:
https://ethereum.stackexchange.com/questions/550/which-cryptographic-hash-function-does-ethereum-use
There was a problem hiding this comment.
Yes this is different @terenc3t - I think we should just use go-ethereum/common with its BytesToHash methods everywhere instead and deprecate our hashutils package
nisdas
approved these changes
Dec 5, 2018
KimiWu123
pushed a commit
to KimiWu123/prysm
that referenced
this pull request
Dec 15, 2018
* switched from blake2b to sha3 * fixed test * use sha3 from eth1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched from blake2b to sha3/keccak-256 for our
HashfunctionSee rationale: ethereum/consensus-specs#227