Bellatrix evaluators #10506
Merged
Bellatrix evaluators #10506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into bellatrxiE2E
(cherry picked from commit f362af9862db680b6352692217ad5c08d44a1e86) # Conflicts: # proto/prysm/v1alpha1/validator.pb.go
# Conflicts: # config/params/loader.go # proto/prysm/v1alpha1/validator.pb.go
# Conflicts: # beacon-chain/rpc/prysm/v1alpha1/beacon/blocks.go # deps.bzl # go.mod # go.sum # testing/endtoend/components/beacon_node.go # testing/endtoend/components/eth1/transactions.go # testing/endtoend/deps.bzl # testing/endtoend/endtoend_test.go
rkapka
added
Ready For Review
nisdas
reviewed
Apr 11, 2022
| if err != nil { | ||
| return errors.Wrap(err, "failed to get blocks from beacon-chain") | ||
| } | ||
| expectedTxNum := int(math.Round(float64(params.E2ETestConfig().SlotsPerEpoch) * float64(e2e.NumOfExecEngineTxs) * 0.7)) |
There was a problem hiding this comment.
parameterize the 0.7 value. If desire in the future, we can lower/increase it.
nisdas
approved these changes
Apr 11, 2022
| var NumOfExecEngineTxs = uint64(200) | ||
|
|
||
| // ExpectedExecEngineTxsThreshold is the portion of execution engine transactions we expect to find in blocks. | ||
| var ExpectedExecEngineTxsThreshold = 0.7 |
There was a problem hiding this comment.
Why 0.7? Shouldn't it be closer to 100%?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Part of #10228. This PR introduces two new E2E evaluators:
bellatrix_fork_transitiontransactions_present_at_epoch