Test VMC contract in golang #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… geth-sharding
enriquefynn
force-pushed
the
geth-sharding
branch
from
91ce8cd
to
e1e1c40
Compare
enriquefynn
force-pushed
the
geth-sharding
branch
from
e1e1c40
to
aeee940
Compare
prestonvanloon
requested changes
Feb 8, 2018
| addr = crypto.PubkeyToAddress(key.PublicKey) | ||
| ) | ||
|
|
||
| func TestContractCreation(t *testing.T) { |
There was a problem hiding this comment.
Can you be more specific? This is testing a lot of things other than just deploying the contract.
Please split up these into smaller tests where each test method has a suite of test conditions and expected output.
| accountBalance, _ := new(big.Int).SetString("1000000000000000000000", 10) | ||
| contractBackend := backends.NewSimulatedBackend(core.GenesisAlloc{addr: {Balance: accountBalance}}) | ||
| transactOpts := bind.NewKeyedTransactor(key) | ||
| callOpts := bind.CallOpts{} |
There was a problem hiding this comment.
This can be inline on line 33
| contractBackend := backends.NewSimulatedBackend(core.GenesisAlloc{addr: {Balance: accountBalance}}) | ||
| transactOpts := bind.NewKeyedTransactor(key) | ||
| callOpts := bind.CallOpts{} | ||
| filterOpts := bind.FilterOpts{} |
There was a problem hiding this comment.
This can be inline on line 47
| if depositsIterator.Event.Index.Cmp(big.NewInt(0)) != 0 { | ||
| t.Fatalf("Validator index mismatch: %d should be 0", depositsIterator.Event.Index) | ||
| } | ||
| fmt.Printf("%x\n", depositsIterator.Event.Validator) |
There was a problem hiding this comment.
No need for this print statement
Known issue: Test failing until upstream merges fix with abigen
… into geth-sharding
prestonvanloon
approved these changes
Feb 16, 2018
prestonvanloon
added a commit
that referenced
this pull request
Jul 22, 2018
Test VMC contract in golang
prestonvanloon
added a commit
that referenced
this pull request
Jul 22, 2018
Test VMC contract in golang Former-commit-id: f0ede01
protolambda
pushed a commit
to protolambda/prysm
that referenced
this pull request
Oct 9, 2022
EIP-4844 Blobs sidecar API endpoint (rebased)
Redidacove
pushed a commit
to Redidacove/prysm
that referenced
this pull request
Aug 13, 2024
Co-authored-by: Mário Havel <61149543+taxmeifyoucan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unpacked arguments for the CollationAdded event
New VMC go bindings