Update to new terms across all our code #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
requested changes
Mar 8, 2018
sharding/client.go
Outdated
| func (c *Client) VMCCaller() *contracts.VMCCaller { | ||
| return &c.vmc.VMCCaller | ||
| // VMCCaller to interact with the sharding manager contract. | ||
| func (c *Client) VMCCaller() *contracts.SMCCaller { |
|
Please run tests and lint. Travis is red |
|
Will do. Travis is red because VMC.sol and the bindings are still old |
terencechain
changed the title
prestonvanloon
requested changes
Mar 9, 2018
sharding/collator.go
Outdated
| // Checks if our deposit has gone through according to the VMC | ||
| b, err := c.VMCCaller().IsValidatorDeposited(&bind.CallOpts{}, account.Address) | ||
| // Checks if our deposit has gone through according to the SMC | ||
| b, err := c.SMCCaller().IsCollatorDeposited(&bind.CallOpts{}, account.Address) |
There was a problem hiding this comment.
Just return the result of this method call. No need for the following if else statement
prestonvanloon
requested changes
Mar 9, 2018
sharding/collator.go
Outdated
| return false, err | ||
| } | ||
| // Checks if our deposit has gone through according to the SMC | ||
| b, err := c.SMCCaller().IsCollatorDeposited(&bind.CallOpts{}, account.Address) |
There was a problem hiding this comment.
return c.SMCCaller()...
No need for these variables
terencechain
changed the title
|
Rename from vmc.go to smc.go |
prestonvanloon
approved these changes
Mar 9, 2018
Redidacove
pushed a commit
to Redidacove/prysm
that referenced
this pull request
Aug 13, 2024
Ashely Yan has added her updates of week 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the list of todos to update terms across all our code