Attestation proposing: more tests #7267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazdagi
changed the title
farazdagi
changed the title
farazdagi
added
OK to merge
Ready For Review
terencechain
approved these changes
Sep 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #7267 +/- ##
==========================================
+ Coverage 59.38% 59.41% +0.03%
==========================================
Files 418 419 +1
Lines 29961 29963 +2
==========================================
+ Hits 17793 17804 +11
+ Misses 9255 9247 -8
+ Partials 2913 2912 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Improves profitability by:Selecting earliest validators' votes only: if validator have their vote logged in some other aggregate already, it will not be included twice -- making double votes in proposed blocks possible only if validator submits votes in different committees.Selecting most populous aggregatesAfter discussion with @terencechain this PR will include:
Which issues(s) does this PR fix?
Closes #4507
Other notes for review