Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves test coverage of init-sync queue #7320

Merged
merged 14 commits into from
Sep 24, 2020
Merged

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Other / Better Tests

What does this PR do? Why is it needed?

  • We need to make sure that FSMs state transition functions are tested completely (for all valid input states, output states, possible execution routes). Otherwise, it is hard to guarantee correct execution of state machine functioning when we need to hot patch init-sync (we had to do that on the start of Medalla).
  • This PR aims for a full coverage of state transition functions (and the rest of the queue component, if there will some untested areas left).

Which issues(s) does this PR fix?

N/A

Other notes for review

@farazdagi farazdagi added the Test label Sep 23, 2020
@farazdagi farazdagi self-assigned this Sep 23, 2020
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #7320 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7320      +/-   ##
==========================================
- Coverage   60.08%   59.99%   -0.10%     
==========================================
  Files         416      416              
  Lines       30017    29888     -129     
==========================================
- Hits        18037    17930     -107     
- Misses       9024     9028       +4     
+ Partials     2956     2930      -26     

@farazdagi farazdagi marked this pull request as ready for review September 24, 2020 10:14
@farazdagi farazdagi requested a review from a team as a code owner September 24, 2020 10:14
@farazdagi farazdagi added OK to merge Ready For Review A pull request ready for code review labels Sep 24, 2020
Copy link
Member

@nisdas nisdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great test cases 🥇

@nisdas nisdas merged commit 5b81400 into master Sep 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the init-sync-queue-more-tests branch September 24, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants