Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect lower then minimal block slot as slashble #7868

Closed
wants to merge 8 commits into from

Conversation

shayzluf
Copy link
Contributor

Feature

What does this PR do? Why is it needed?
This pr conform to the interchange format EIP by considering a request to sign slot that is lower then min signed slot as slashable

Which issues(s) does this PR fix?

Part of #7813

Other notes for review

@shayzluf shayzluf requested a review from a team as a code owner November 20, 2020 12:27
@shayzluf shayzluf requested review from rauljordan, terencechain and nisdas and removed request for a team November 20, 2020 12:27
@shayzluf shayzluf changed the title Minimal block signing protection Detect lower then minimal block slot as slashble Nov 20, 2020
…into minimal_block_signing

# Conflicts:
#	validator/db/iface/interface.go
#	validator/db/kv/manage_test.go
#	validator/db/kv/proposal_history_v2.go
#	validator/db/kv/proposal_history_v2_test.go
#	validator/slashing-protection/local/standard-protection-format/import_test.go
@shayzluf
Copy link
Contributor Author

Closed for #7952

@shayzluf shayzluf closed this Nov 25, 2020
@rauljordan rauljordan deleted the minimal_block_signing branch March 12, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant