Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attestation pool: continue if bad #8550

Merged
merged 4 commits into from
Mar 4, 2021
Merged

Conversation

terencechain
Copy link
Member

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

When saving attestations to the pool, we should continue and not stop when run into bad attestation in the pool. Today It's not possible to have bad attestation in the pool, but this is still a good fix regardless.

Which issues(s) does this PR fix?

N/A

Other notes for review

N/A

@terencechain terencechain added the Ready For Review A pull request ready for code review label Mar 3, 2021
@terencechain terencechain self-assigned this Mar 3, 2021
@terencechain terencechain requested a review from a team as a code owner March 3, 2021 16:33
@prylabs-bulldozer prylabs-bulldozer bot merged commit 1c7c62c into develop Mar 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the save-attestations branch March 4, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants