Support building on macOS #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wrap stat and xattr in ifdef directives. - Remove -Bstatic and -Bdynamic arguments in Makefile because the arguments aren't needed and break linking.
|
Thanks a lot "mpctx", I just also tested this commit on several Linux systems and a Mac system and it worked nicely. I just merged it into my own fork of metastore (https://gitlab.com/makhlaghi/metastore-fork), combining it with some minor issues I had to fix. I will be using this fork until the new pull requests implemented in the main project. |
Closed
|
Thank you, @mpctx, for your metastore contribution. As it is right now, it's rather a no-go, as adding more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arguments aren't needed and break linking.
Tested on Linux Mint and macOS High Sierra.