Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Mongoose connection and implemented MetagameEvent handler #55

Merged
merged 44 commits into from
Jul 21, 2020

Conversation

Maelstromeous
Copy link
Member

@Maelstromeous Maelstromeous commented Jul 20, 2020

Implemented Mongoose and MetagameEvent handling including writing to database and updating on end.

Closes #48

Maelstromeous and others added 27 commits July 15, 2020 01:20
Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
@Maelstromeous Maelstromeous added enhancement New feature or request p1 Show-stopping issues labels Jul 20, 2020
@Maelstromeous Maelstromeous added this to the 2.0 Revival Pre-Alpha milestone Jul 20, 2020
@Maelstromeous Maelstromeous changed the title Created Mongoose connection and made a start on models Created Mongoose connection and implemented MetagameEvent handler Jul 20, 2020
'AlertDeath',
alertDeathSchema,
))
.inSingletonScope();
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is where all of the models will be defined and available to be injected into handlers.

@Maelstromeous Maelstromeous mentioned this pull request Jul 20, 2020
25 tasks
Copy link
Member

@microwavekonijn microwavekonijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you still need the priority feature for services? Or are you already working on that?

private _alerts: Alert[] = [];

public handleMetagameEvent(mge: MetagameEventEvent): boolean {
constructor(
@inject(TYPES.alertModelFactory) factory: MongooseModelFactory<AlertInterface>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

private readonly alertDeathModelFactory: MongooseModelFactory<AlertDeathInterface>;

constructor(
@inject(TYPES.playerHandlerInterface) playerHandler: PlayerHandlerInterface,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

@Maelstromeous
Copy link
Member Author

Looks good. Do you still need the priority feature for services? Or are you already working on that?

I've managed to get away with it without requiring it. Check branch features/45-death-event

@Maelstromeous Maelstromeous merged commit 6470355 into revive Jul 21, 2020
@Maelstromeous Maelstromeous deleted the features/48-database-models branch July 21, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p1 Show-stopping issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Database connection
3 participants