Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ps2dev sdk ships an incomplete opusfile install #499

Open
madebr opened this issue Jan 12, 2024 · 5 comments
Open

The ps2dev sdk ships an incomplete opusfile install #499

madebr opened this issue Jan 12, 2024 · 5 comments

Comments

@madebr
Copy link

madebr commented Jan 12, 2024

When configuring SDL3_mixer using CMake, OpusFileConfig.cmake fails to include opusfileTargets.cmake.
I'm using the ps2dev/ps2dev docker container.

 CMake Error at /usr/local/ps2dev/ps2sdk/ports/lib/cmake/opusfile/OpusFileConfig.cmake:74 (include):
  -- Using system opusfile
    include could not find requested file:
  
      /usr/local/ps2dev/ps2sdk/ports/lib/cmake/opusfile/opusfileTargets.cmake
  Call Stack (most recent call first):
    CMakeLists.txt:470 (find_package)

https://github.com/madebr/setup-sdl-test/actions/runs/7508233610/job/20443307429#step:5:69

@fjtrujy
Copy link
Member

fjtrujy commented Mar 26, 2024

When configuring SDL3_mixer using CMake, OpusFileConfig.cmake fails to include opusfileTargets.cmake. I'm using the ps2dev/ps2dev docker container.

 CMake Error at /usr/local/ps2dev/ps2sdk/ports/lib/cmake/opusfile/OpusFileConfig.cmake:74 (include):
  -- Using system opusfile
    include could not find requested file:
  
      /usr/local/ps2dev/ps2sdk/ports/lib/cmake/opusfile/opusfileTargets.cmake
  Call Stack (most recent call first):
    CMakeLists.txt:470 (find_package)

https://github.com/madebr/setup-sdl-test/actions/runs/7508233610/job/20443307429#step:5:69

Could it be a capitalization problem?
opusfileTargets.cmake vs OpusFileTargets.cmake

Screenshot 2024-03-26 at 13 32 37

We are also using this concrete hash for opusfile https://github.com/ps2dev/ps2sdk-ports/blob/master/build-cmakelibs.sh#L66

Let me know, if we are missing something here...
Cheers.

@fjtrujy
Copy link
Member

fjtrujy commented Mar 26, 2024

It is indeed an issue in the opusFile library, more concretely it was done in this commit:
xiph/opusfile@856efa6

Where they forgot to also update this line:
https://github.com/xiph/opusfile/blob/master/cmake/OpusFileConfig.cmake.in#L50

I will create a PR for them.

Cheers.

@fjtrujy
Copy link
Member

fjtrujy commented Mar 26, 2024

There was already a PR created for that: xiph/opusfile#42

@fjtrujy
Copy link
Member

fjtrujy commented Mar 26, 2024

In the worst scenario, we can update opusfile in the ps2sdk-port to point just right before that guilty commit.
xiph/opusfile@81abcb7
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@madebr @fjtrujy and others