-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bb:pr:create): Ability to override PR Title and Description #55
Conversation
WalkthroughThis update enhances the pull request creation process by introducing distinct parameters for titles and descriptions, promoting clarity and usability. Multiple functions across various modules have been modified to handle these parameters separately, ensuring a more intuitive interface. Additionally, the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PR_API
participant Utils
User->>PR_API: create(title, description)
PR_API->>Utils: pull_request_body(title, description)
Utils-->>PR_API: formatted_body
PR_API-->>User: return formatted pull request
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
72971b7
to
d8420cf
Compare
d8420cf
to
ccd125c
Compare
Default PR Title & Description can be overridden as part PR creation, if empty defaults to existing values from the commit header and body
ccd125c
to
d543916
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pdm.lock
is excluded by!**/*.lock
Files selected for processing (9)
- .gitignore (1 hunks)
- bb/pr/init.py (4 hunks)
- bb/pr/create.py (5 hunks)
- bb/utils/api.py (3 hunks)
- bb/utils/helper.py (2 hunks)
- bb/utils/richprint.py (1 hunks)
- requirements.txt (1 hunks)
- tests/props.py (1 hunks)
- tests/test_api.py (2 hunks)
Files skipped from review as they are similar to previous changes (8)
- .gitignore
- bb/pr/init.py
- bb/utils/api.py
- bb/utils/helper.py
- bb/utils/richprint.py
- requirements.txt
- tests/props.py
- tests/test_api.py
Additional comments not posted (7)
bb/pr/create.py (7)
42-43
: Parameter update: Separatetitle
anddescription
.The function now takes
title
anddescription
as separate parameters, improving clarity and usability.
54-55
: Docstring update: Reflect parameter changes.The docstring correctly reflects the updated parameters
title
anddescription
.
86-87
: Correct usage of new parameters.The new parameters
title
anddescription
are correctly used in the table for displaying PR details.
95-97
: Parameter update: Includetitle
anddescription
.The function now includes
title
anddescription
parameters, enhancing flexibility in PR creation.
107-108
: Docstring update: Reflect parameter changes.The docstring correctly reflects the updated parameters
title
anddescription
.
129-129
: Correct usage of new parameters.The new parameters
title
anddescription
are correctly passed to thegather_facts
function.
136-137
: Correct usage of new parameters.The new parameters
title
anddescription
are correctly used in thepull_request_body
function call.
Quality Gate passedIssues Measures |
Default PR Title & Description can be overridden as part PR creation, if empty defaults to existing values from the commit header and body
Summary by CodeRabbit
pre-commit
package version to enhance the development workflow..gitignore
entry to ignore test-related files and directories for a cleaner repository.