Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable emoji in output #223

Closed
giuscri opened this issue May 18, 2018 · 9 comments
Closed

Allow to disable emoji in output #223

giuscri opened this issue May 18, 2018 · 9 comments

Comments

@giuscri
Copy link

giuscri commented May 18, 2018

As an environment variable (e.g. BLACK_HIDE_EMOJIS) or as an option.

@JelleZijlstra
Copy link
Collaborator

What's your motivation?

@giuscri
Copy link
Author

giuscri commented May 19, 2018

emoji support can be problematic on some platform. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30045

The reason why I noticed you can't toggle emojis is that my terminal crashed when using black . Currently I solved by sending stderr of black to devnull.

@ambv
Copy link
Collaborator

ambv commented May 19, 2018

This sounds like something that should be fixed or worked around in your terminal, not in end-user tools that use Unicode characters. I happen to have a non-Latin 1 character in my first name so I'm rather sensitive to bad Unicode support.

@giuscri
Copy link
Author

giuscri commented May 20, 2018

I see your point. Also, I didn't noticed there's a --quiet option in black. Closing this.

@waldronfaulkner
Copy link

Opinion: there should be an option to disable emoji output. There are a lot of people—old or not—who feel emojis are dumb and unprofessional and just lower the tone of everyday work when they're spattered all across our consoles

@ArsenArsen
Copy link

Hi! Some of my co-developers raised concerns about emojis looking out of place in CI output, so I'd like to propose a BLACK_NO_FUN environment variable that allows for them to be disabled on site, if the user hates fun.

I see that it's been proposed to use --quiet, the issue with that, though, is that it does not show other information too, so it's not worth it.

PS: I'd be fine with contributing this myself, but I'd like to get prior discussion with the maintainers.

Thanks in advance.

@jap
Copy link

jap commented Aug 16, 2021

I just ran across some code making use of emojis, all-caps words and coloring in a script that calls black and some other formatters and linters.
The reason was to make sure it stands out more than black's output. This is just a race to the bottom for attention :(

@TimZaman
Copy link

TimZaman commented Mar 3, 2022

unicode support is fine, but just like jap said - there is no need to hijack attention what is otherwise a calming terminal experience.

@draeath
Copy link

draeath commented Apr 28, 2022

I'd like to see this as well. Gives it a non-professional feel, which is unfair I know, but there it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants