Skip to content

Add -n flag to not print emojis#1270

Closed
austenadler wants to merge 2 commits into
psf:masterfrom
austenadler:feature/no-emojis
Closed

Add -n flag to not print emojis#1270
austenadler wants to merge 2 commits into
psf:masterfrom
austenadler:feature/no-emojis

Conversation

@austenadler
Copy link
Copy Markdown

Is your feature request related to a problem? Please describe. I want to be able to disable emojis from being printed on success/failure

Describe the solution you'd like Either emojis removed entirely, or an option that disables them (this merge request implements the latter in -n/--no-emojis)

Describe alternatives you've considered Running something like black ... | sed 's/[^[:alnum:]]//g' but this is bad design for obvious reasons. Also considered looking at any translation implementations (no emoji could be a 'dialect' of English), but I don't know how to do this in python.

@austenadler
Copy link
Copy Markdown
Author

Will add documentation for this. Should I write a test too?

@hugovk
Copy link
Copy Markdown
Contributor

hugovk commented Feb 11, 2020

Duplicate of #223, #1031 and #1255.

@ambv
Copy link
Copy Markdown
Collaborator

ambv commented Mar 3, 2020

This sounds like something that should be fixed or worked around in your terminal, not in end-user tools that use Unicode characters. I happen to have a non-Latin 1 character in my first name so I'm rather sensitive to bad Unicode support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants