Add -n flag to not print emojis#1270
Closed
austenadler wants to merge 2 commits into
Closed
Conversation
Author
|
Will add documentation for this. Should I write a test too? |
Contributor
Collaborator
|
This sounds like something that should be fixed or worked around in your terminal, not in end-user tools that use Unicode characters. I happen to have a non-Latin 1 character in my first name so I'm rather sensitive to bad Unicode support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please describe. I want to be able to disable emojis from being printed on success/failure
Describe the solution you'd like Either emojis removed entirely, or an option that disables them (this merge request implements the latter in
-n/--no-emojis)Describe alternatives you've considered Running something like
black ... | sed 's/[^[:alnum:]]//g'but this is bad design for obvious reasons. Also considered looking at any translation implementations (no emoji could be a 'dialect' of English), but I don't know how to do this in python.