Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second run of tox -e py results in a test error for test marked with no_python2 #2369

Merged
merged 4 commits into from
Jul 11, 2021
Merged

Second run of tox -e py results in a test error for test marked with no_python2 #2369

merged 4 commits into from
Jul 11, 2021

Conversation

MarcoGorelli
Copy link
Contributor

closes #2367

I ran

rm -rf .tox
tox -e py
tox -e py

and it worked fine

cc @jack1142

JelleZijlstra
JelleZijlstra reviewed Jul 11, 2021
View reviewed changes
tox.ini Outdated
@@ -4,6 +4,7 @@ envlist = {,ci-}py{36,37,38,39},fuzz
[testenv]
setenv = PYTHONPATH = {toxinidir}/src
skip_install = True
recreate= True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
recreate= True
recreate = True

@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Jul 11, 2021
JelleZijlstra
JelleZijlstra reviewed Jul 11, 2021
View reviewed changes
tox.ini
@@ -4,6 +4,7 @@ envlist = {,ci-}py{36,37,38,39},fuzz
[testenv]
setenv = PYTHONPATH = {toxinidir}/src
skip_install = True
recreate = True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could use a comment explaining why we do this and linking back to the issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good point, thanks!

ichard26
ichard26 approved these changes Jul 11, 2021
View reviewed changes
Copy link
Collaborator

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks mate!

@JelleZijlstra JelleZijlstra merged commit 548d699 into psf:main Jul 11, 2021
@MarcoGorelli MarcoGorelli deleted the tox-should-pass-if-run-twice branch July 11, 2021 20:05
@Jackenmen Jackenmen mentioned this pull request Aug 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@ichard26 ichard26 ichard26 approved these changes

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Second run of tox -e py results in a test error for test marked with no_python2
3 participants
@MarcoGorelli @JelleZijlstra @ichard26