-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some unneeded exceptions from mypy.ini #2557
Conversation
Looks good but you merge conflicted yourself :) |
Huh, I wonder what's different this time as Łukasz had one hell of a ride trying to silence mypy for _unicodefun when we first added support for Click 8+. |
fe5774c
to
8131599
Compare
My best guess is that it's because mypy.ini hard codes python 3.6? |
if only community/community#4477 - it were possible to avoid this. I prefer to make two CRs instead of one if the changes are independent. I consider it a shortcoming of github that I can't pre-handle this by stacking them. |
Yeah if only. I'm working on getting black compiled with mypyc and it's failing because of the exception that we previously silenced: https://github.com/ichard26/black-mypyc-wheels/runs/4040805225?check_suite_focus=true#step:5:197 *sigh* |
Dah! Probably something like would this allow you to handle it w/o ignoring unused ignores broadly all the way across
^ I just confirmed this works |
Put up #2573 in case you want it |
Did you check with mypyc? I ask that because it's rather strict (makes sense as a compiler) so even mypy passing code might not work. I can check regardless. |
I did not check it. Good point about its strictness. I suspect the old ignores were not needed w/ mypyc because the library imports were probably coming in as |
Description
I removed these and found that mypy still passed (particularly since it's hard coded to target python 3.6 currently)
Checklist - did you ...