add more flake8 lints #2653
Merged
add more flake8 lints #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooperlees
approved these changes
Nov 28, 2021
There was a problem hiding this comment.
Thanks for the contribution. I'm a big fan of flake8-comprehensions ... It's found many CPU savings on codes bases I've worked on so this is a goodadditon for black.
I've not used flake8-simplify so would love some other maintainers thoughts there, but a quick look at it's checks seem sane.
Please add an addition into the CHANGES.md please for this PR #2653
danieleades
force-pushed
the
lint/more-lake8-lints
branch
from
467da49
to
13193a2
Compare
|
Going to merge - If any other maintainer etc. dislike |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds some additional flake8 lints to the pre-commit config