Remove hidden import from PyInstaller build #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent 2021.4 release of pyinstaller-hooks-contrib now contains a built-in hook for platformdirs. Manually specifying the hidden import arg should no longer be needed.
JelleZijlstra
added
the
skip news
ichard26
approved these changes
Nov 30, 2021
cooperlees
approved these changes
Nov 30, 2021
I tested the macOS binary, but also confirmed that the hooks were being picked up on all the platforms based on the logs. |
|
Thanks. Sounds good to me then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The recent 2021.4 release of pyinstaller-hooks-contrib now contains a
built-in hook for platformdirs. Manually specifying the hidden import
arg should no longer be needed.
The latest release of pyinstaller-hooks-contrib is installed when installing
PyInstaller, so reverting #2466 is all that is needed.
Checklist - did you ...
I did not add a changelog entry for this as there should be no change in behavior to the end user.