Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve new flake8-bugbear errors (B020) #2950

Merged
merged 3 commits into from Mar 24, 2022
Merged

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Mar 24, 2022

Description

Closes #2949. Fixes a couple places where we were using the same variable name as we are iterating over.

Checklist - did you ...

  • Add a CHANGELOG entry if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@github-actions
Copy link

@github-actions github-actions bot commented Mar 24, 2022

diff-shades reports zero changes comparing this PR (78c8a83) to main (3800ebd).


What is this? | Workflow run | diff-shades documentation

CHANGES.md Outdated
@@ -41,6 +41,7 @@
<!-- For example, Docker, GitHub Actions, pre-commit, editors -->

- Move test to disable plugin in Vim/Neovim, which speeds up loading (#2896)
- Resolve new flake8-bugbear errors (B020) (#2950)
Copy link
Collaborator

@JelleZijlstra JelleZijlstra Mar 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can omit this since there's no effect on end users

CHANGES.md Outdated Show resolved Hide resolved
@JelleZijlstra JelleZijlstra added the skip news label Mar 24, 2022
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Thank you!

@JelleZijlstra JelleZijlstra self-assigned this Mar 24, 2022
@cooperlees
Copy link
Collaborator

@cooperlees cooperlees commented Mar 24, 2022

Awesome, Joe, don't burn yourself out now (Joe's also been busy at work on flake8-bugbear ...)

Copy link
Collaborator

@ichard26 ichard26 left a comment

Thanks! This will unblock #2891 :)

@jpy-git
Copy link
Contributor Author

@jpy-git jpy-git commented Mar 24, 2022

haha thanks all 😄

@ichard26 ichard26 merged commit 14d84ba into psf:main Mar 24, 2022
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants