added parsable line number and col number #3160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cibinmathew
force-pushed
the
error_report_style
branch
3 times, most recently
from
13e0889
to
3388d56
Compare
cibinmathew
force-pushed
the
error_report_style
branch
from
fe887c8
to
5da3866
Compare
cibinmathew
force-pushed
the
error_report_style
branch
from
4423621
to
8b0aad6
Compare
cibinmathew
commented
Aug 13, 2022
| """Increment the counter for failed reformatting. Write out a message.""" | ||
| err(f"error: cannot format {src}: {message}") | ||
| if lineno and column: |
There was a problem hiding this comment.
Currently adding line_number/column only if both are available
|
Thanks, but this PR is stale and not currently close to mergeable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the error report style to file:line:column to make it parsable for external editors etc
Fixes #3157
Checklist - did you ...