(🐞) blackd: fix issue for mishandling single character input - #3558
Merged
Conversation
KotlinIsland
force-pushed
the
fix/blackd-one-char
branch
from
February 10, 2023 00:48
1ebb99d to
bd0221d
Compare
zsol
reviewed
Feb 10, 2023
zsol
left a comment
zsol
left a comment
Collaborator
There was a problem hiding this comment.
Nice catch! Changes look good after removing that del
zsol
reviewed
Feb 10, 2023
zsol
left a comment
zsol
left a comment
Collaborator
There was a problem hiding this comment.
Oh one more thing, could you please add a simple test case for this?
KotlinIsland
force-pushed
the
fix/blackd-one-char
branch
from
February 12, 2023 09:18
bd0221d to
3f0ecbe
Compare
Collaborator
|
Looks like the test is failing |
KotlinIsland
force-pushed
the
fix/blackd-one-char
branch
from
May 5, 2023 06:59
3f0ecbe to
3a9ca87
Compare
Contributor
Author
|
@zsol Sorry! this must have fell off my radar somehow. |
hauntsaninja
reviewed
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I found this ladybug where if you send one character to blackd it will 500 😳. I created this defect in #3257
Checklist - did you ...
CHANGES.mdif necessary?❓ Question
Why is the
blackdsection ofCHANGES.mditalic?