Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Black PyCharm 2023.2 integration instructions #3839

Merged
merged 6 commits into from
Sep 8, 2023

Conversation

jonashaag
Copy link
Contributor

I'm a bit uncreative as to what users might want to configure there

image

Description

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@jonashaag jonashaag changed the base branch from stable to main August 15, 2023 15:52
jonashaag and others added 2 commits August 15, 2023 17:53
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@@ -21,6 +22,17 @@ The first option is the simplest to set up and formats the fastest (by spinning
startup cost on subsequent formats), but if you would prefer to not install a
Copy link
Collaborator

@hauntsaninja hauntsaninja Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes what "the first option" in this paragraph refers to; I think needs some reworking

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

@hauntsaninja hauntsaninja added the skip news Pull requests that don't need a changelog entry. label Aug 16, 2023
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (though I don't use PyCharm and haven't tried this).

@hauntsaninja are you OK with this PR now? (I can't merge since you requested changes.)

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me (also do not use pycharm and haven't tried)

@hauntsaninja hauntsaninja merged commit 74d3009 into psf:main Sep 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants