Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block aiohttp==3.9.0 from being installed in CI on Windows/pypy #4051

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

AlexWaygood
Copy link
Contributor

Description

aiohttp==3.9.0 fails to import if you're using PyPy on Windows: see aio-libs/aiohttp#7848. This is currently causing our Windows/PyPy CI job to fail on every PR. We're using PyPy3.8 in CI, but bumping to PyPy3.9 in CI doesn't fix the problem: see the failing CI on the latest commit of #4035.

This PR just blocks aiohttp==3.9.0 from being installed in CI, to make things green again.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@AlexWaygood AlexWaygood marked this pull request as ready for review November 18, 2023 17:37
@cooperlees
Copy link
Collaborator

I think it's better to just not test for pypy (even just on windows) for now if we can easily in the action instead ... Is that doable?

@AlexWaygood
Copy link
Contributor Author

I could do something like this, so that aiohttp==3.9.0 is only banned for the Windows/PyPy combination?

--- a/pyproject.toml
+++ b/pyproject.toml
@@ -76,7 +76,8 @@ dynamic = ["readme", "version"]
 colorama = ["colorama>=0.4.3"]
 uvloop = ["uvloop>=0.15.2"]
 d = [
-  "aiohttp>=3.7.4, !=3.9.0",
+  "aiohttp>=3.7.4; sys_platform != 'win32' or implementation_name != 'pypy'",
+  "aiohttp>=3.7.4, !=3.9.0; sys_platform == 'win32' and implementation_name == 'pypy'",
 ]
 jupyter = [
   "ipython>=7.8.0",

@cooperlees
Copy link
Collaborator

Damn, that's using all the specifiers! Nice.

I'll merge that so we block it from as little as possible to maybe help others + potentially find more bugs ...

@cooperlees cooperlees added the skip news Pull requests that don't need a changelog entry. label Nov 18, 2023
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP440 Version specifier soup.

Accepting as this will be temporary until we get a fix into aiohttp 3.9.X.

@AlexWaygood AlexWaygood changed the title Block aiohttp==3.9.0 from being installed in CI Block aiohttp==3.9.0 from being installed in CI on Windows/pypy Nov 18, 2023
@JelleZijlstra JelleZijlstra merged commit 85b1c71 into psf:main Nov 18, 2023
40 of 42 checks passed
@AlexWaygood AlexWaygood deleted the fix-pypy-ci branch November 18, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants