Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pre-commit): raise minimum_pre_commit_version (#4065) #4067

Closed
wants to merge 3 commits into from

Conversation

davidculley
Copy link
Contributor

@davidculley davidculley commented Nov 21, 2023

Description

The changes made in Pull Request #3940 require version 3.2.0 of pre-commit (or newer). See #3940 (comment)

We should also raise minimum_pre_commit_version if we want to go from the proposal made in #4041

stages: [commit, merge-commit, push, manual]

to

stages: [pre-commit, pre-merge-commit, pre-push, manual]

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@martin-thoma
Copy link

This would fix #4065

@AlexWaygood
Copy link
Contributor

#4041 is the better solution, no?

@davidculley
Copy link
Contributor Author

davidculley commented Nov 22, 2023

#4041 is the better solution, no?

It's definitely a solution that requires no work on the side of the user (except for updating black, of course), whereas the more future-proof solution proposed in this very PR (#4067) might force some users to update their installation of pre-commit.

However, probably sometime around mid-to-late 2024, with the release of pre-commit version 4.x.x, the solution proposed in #4041 will stop working and there will be no way around #4067 anymore if one wants to use version 4.x.x of pre-commit (see here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants