Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify chained expressions and remove unused param #4114

Conversation

Anupya
Copy link
Contributor

@Anupya Anupya commented Dec 16, 2023

Description

  • previous was unused in is_split_after_delimiter so removed it
  • rename reversed in enumerate_with_length to is_reversed because reversed is a Python built-in function
Screenshot 2023-12-15 at 10 11 54 PM
  • Simpify if statements to make them easier to read
  • Fix docstrings (well-formed and fast-forward is one word, Therefore and Otherwise needs a comma after, remove be be, should be a part instead of apart)

Checklist - did you ...

None of the below are necessary!

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@Anupya Anupya marked this pull request as ready for review December 16, 2023 04:58
Copy link

github-actions bot commented Dec 16, 2023

diff-shades reports zero changes comparing this PR (c84fada) to main (1b831f2).


What is this? | Workflow run | diff-shades documentation

@hauntsaninja hauntsaninja added the skip news Pull requests that don't need a changelog entry. label Dec 16, 2023
@hauntsaninja hauntsaninja merged commit 5178614 into psf:main Dec 28, 2023
46 checks passed
@hauntsaninja
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants