You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second argument to right_hand_split() is an int (line length), but we were passing supports_trailing_commas as a bool. Mypy didn't catch this because bool is a subclass of int. Found this while working on a fix for #759 because I changed the type of supports_trailing_commas.
This affects one test that is now formatted differently, and it also causes a fair number of changes in our codebase. Now that I look at it, in most cases I actually feel like the old formatting is better, so maybe we need to do something different than just fix the type mismatch.
Oh my, this one's embarrassing! It dates all the way back to 3eea3aa when I was fixing trailers (content with brackets) being unnecessarily exploded into their own lines after a dedented closing bracket.
This affects one test that is now formatted differently, and it also causes a fair number of changes in our codebase. Now that I look at it, in most cases I actually feel like the old formatting is better, so maybe we need to do something different than just fix the type mismatch.
I had the same experience in one of our codebases where the old formatting was generally better. Is there an issue or plans to address this?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second argument to
right_hand_split()
is an int (line length), but we were passingsupports_trailing_commas
as a bool. Mypy didn't catch this because bool is a subclass of int. Found this while working on a fix for #759 because I changed the type ofsupports_trailing_commas
.This affects one test that is now formatted differently, and it also causes a fair number of changes in our codebase. Now that I look at it, in most cases I actually feel like the old formatting is better, so maybe we need to do something different than just fix the type mismatch.