Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialize.py function fails with HTTPResonse has no attribute "strict" #293

Closed
aleksaw opened this issue May 4, 2023 · 6 comments · Fixed by #301
Closed

serialize.py function fails with HTTPResonse has no attribute "strict" #293

aleksaw opened this issue May 4, 2023 · 6 comments · Fixed by #301

Comments

@aleksaw
Copy link

aleksaw commented May 4, 2023

When running pdm install with no dependencies on python 3.10 and 3.11 I have just started experiencing at error stemming from this line. I don't have a lot of information beyond this since this is for some reason called by pdm sync/install. I do know, that replacing the response.strict part with True got pdm sync to stop crashing.

@aleksaw
Copy link
Author

aleksaw commented May 4, 2023

I also get [TypeError]: HTTPResponse.__init__() got an unexpected keyword argument 'strict' from this line

@dairiki
Copy link
Contributor

dairiki commented May 4, 2023

It has to do with the removal of the strict parameter and attribute from HTTPResponse in urllib3>=2.0.
(Changelog, PR urllib3/urllib3#2064)

A workaround is to pin urllib3<2.

@dairiki
Copy link
Contributor

dairiki commented May 4, 2023

I think this is a dup of #292.

dairiki added a commit to barnhunt/barnhunt that referenced this issue May 5, 2023
@aleksaw
Copy link
Author

aleksaw commented May 5, 2023

Thanks @dairiki ! It seems indeed to be a duplicate.

@t0b3
Copy link

t0b3 commented May 29, 2023

@ionrock now this commit is in - can you release a new version i.e. 0.12.13 for https://pypi.org/project/cachecontrol/#history ?
motivation: this would solve many downstream issues for others eg. depending on latest cachecontrol for CI jobs etc. i.e. those using poetry ...

@graingert
Copy link

@t0b3 looks like 0.13.1 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants