Stop throwing if saving a request fails #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saving a cached request may fail for any number of reasons: * Running out of memory * Running out of disk space * Other IO-related errors Since we have already made the request and received the data we might as well use it instead of dropping it on the floor just because we can't save it to satisfy future requests.
hexagonrecursion
force-pushed
the
catch
branch
from
95fa5dd
to
2886ec7
Compare
|
Correction: this will not help with #145 |
|
@ionrock Ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving a cached request may fail for any number of reasons:
Since we have already made the request and received the data we might
as well use it instead of dropping it on the floor just because we can't
save it to satisfy future requests.
This should make #145, #180 and #238 less severe.