-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup CI through GHA #1
Conversation
@ewdurbin I've also created a |
Creating the branch interferes with GitHub's rename flow, sorry for force closing. |
No worries! Looks like it can just be reopened against the new branch? |
I'm currently fiddling around with the Dockerfile to get that working and came across this issue. I would like to make some changes which are also related to this PR and would like your approval. Mainly I would like to switch over to a This would remove the duplication that currently exists between |
Hi @exhuma, those are on the docket but we're not going to do it all in one go. The first step here is to get CI working. Then we'll need to get the Flask issues resolved, then we can look at modernizing the build infrastructure. The Pipfile we'll likely yank in a future PR. |
Thanks for that merge. That unblocked me from creating a new PR for the customisable port 😉 |
This is the first in a set of PRs we'll need to get httpbin caught up to the year 2023. It currently has some built in requirements for the state of the Pallets projects underpinning Flask that require us to pin to the last known working state in 2018.
This means we're currently only testing on Python 3.7-3.9 because our version of werkzeug is importing classes from
collections
that were removed in 3.10. It looks like we only have 2 tests failing once we upgrade flask due to aContent-Length: 0
header no longer being added to empty responses. I'm assuming this is an intended change, but we'll likely want to figure out potential impact on downstream before changing anything.For now this PR addresses:
flask<1.0.3
itsdangerous<2
jinja2==2.10.0
markupsafe<2.1
werkzeug==0.14.1