Replace localhost with constant

[gaul]

This allows overriding a single constant when using an external httpbin. References gaul/java-httpbin#4.

[kevin1024]

Huh. How does that work? Does your test suite swap out that constant somehow? Would an env var work better?

[gaul]

Yeah this should be an environment variable. Would os.getenv("HTTPBIN_HOST_AND_PORT", 'localhost:80') be OK?

[kevin1024]

I'm worried that HTTPBIN_HOST_AND_PORT would indicate to a potential user that the setting will actually dictate the hostname and port of httpbin the app, when in fact it just allows a third-party test suite user to override the hostname.

Maybe there's some way to name the envvar so that it is obvious that it only affects these tests?

Maybe there's some way to rewrite the assertions so they don't care about the hostname?

Maybe your original idea was better with the contant, and then you could apply a patch before running the tests against java-httpbin?

In general, creating a test suite usable by other httpbin clones isn't exactly in scope of this project. It does seem like that would be pretty cool to be able to reuse the tests though.

[exhuma]

I'm not quite sure I understand what the link between java-httpbin and httpbin is. Is java-httpbin using Jython and import the test-cases? I've quickly skimmed the java-httpbin code and did not see any such reference.

If it's not Jython, then how is a code-change in the Python implementation going to affect java-httpbin?

[kevin1024]

seems to me it's a reimplementation of httpbin in java, and @gaul just thinks it would be cool to be able to use the python httpbin test suite to validate that the java implementation of httpbin works the same as the original python implementation. Am I on the right track @gaul?

[gaul]

java-httpbin is a pure Java reimplementation of httpbin. I am only using the httpbin test suite to ensure conformance.

Thanks for the suggestion to match the URL without the host! I updated the PR to match.

[exhuma]

That makes perfect sense. The new changes also look fine. They are a bit more forgiving but I'd say that's fine.

[kevin1024]

I dig it.