-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace localhost with constant #21
Conversation
Huh. How does that work? Does your test suite swap out that constant somehow? Would an env var work better? |
Yeah this should be an environment variable. Would |
I'm worried that Maybe there's some way to name the envvar so that it is obvious that it only affects these tests? Maybe there's some way to rewrite the assertions so they don't care about the hostname? Maybe your original idea was better with the contant, and then you could apply a patch before running the tests against java-httpbin? In general, creating a test suite usable by other httpbin clones isn't exactly in scope of this project. It does seem like that would be pretty cool to be able to reuse the tests though. |
I'm not quite sure I understand what the link between If it's not Jython, then how is a code-change in the Python implementation going to affect |
java-httpbin is a pure Java reimplementation of httpbin. I am only using the httpbin test suite to ensure conformance. Thanks for the suggestion to match the URL without the host! I updated the PR to match. |
This allows a non-localhost to work, e.g., java-httpbin. References gaul/java-httpbin#4.
That makes perfect sense. The new changes also look fine. They are a bit more forgiving but I'd say that's fine. |
I dig it. |
This allows overriding a single constant when using an external httpbin. References gaul/java-httpbin#4.