Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize graalpython as a python impl with jit #119

Merged
merged 1 commit into from Dec 1, 2021
Merged

Conversation

timfel
Copy link
Contributor

@timfel timfel commented Dec 1, 2021

No description provided.

@vstinner
Copy link
Member

vstinner commented Dec 1, 2021

Oh, nice to see people using pyperf on GraalPython :-) Did you have at look at warmup runs and value runs to see if the timing are steady at some points? My latest study was https://vstinner.readthedocs.io/pypy_warmups.html

The https://arxiv.org/abs/1602.00602 paper disappointed me :-D I tried to implement the changepoint analysis but I failed to find an algorithm for that.

I would also be nice to compute if the distribution is bi-modal (or multi-modal), but again, I don't know how to compute that.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vstinner vstinner merged commit 235d127 into psf:main Dec 1, 2021
@timfel timfel deleted the patch-1 branch December 1, 2021 14:05
@corona10
Copy link
Member

corona10 commented Dec 2, 2021

@timfel
Thank you for the patch. As a big fan of the GraalPython project, I am really happy with the PR.
Do you need this feature officially right now? if so I would like to publish the 2.3.1 by this week.

@timfel
Copy link
Contributor Author

timfel commented Dec 2, 2021

Do you need this feature officially right now? if so I would like to publish the 2.3.1 by this week.

@corona10 I don't need it officially very urgently, but within the next couple of months would be nice :) Until then I've just installed the package off master for local testing

Did you have at look at warmup runs and value runs to see if the timing are steady at some points?

@vstinner I have taken your script and logged the warmup, loops, and values calculated in a pybenchmark run for GraalPython. They are roughly the same as for PyPy, sometimes a bit more, sometimes a bit less. Same as PyPy, some benchmarks are also extremely noisy. I plan to do a bit more analysis, we are just preparing our New Years release right now, so I won't be able to spend too much time on this until around Christmas.

@vstinner
Copy link
Member

vstinner commented Feb 3, 2022

This change is now part of the just released pyperf 2.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants