Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete/unused code #155

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Remove obsolete/unused code #155

merged 2 commits into from
Jan 10, 2023

Conversation

GLEF1X
Copy link
Contributor

@GLEF1X GLEF1X commented Jan 8, 2023

No description provided.

corona10
corona10 approved these changes Jan 8, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GLEF1X Hi Thanks for the contribution. Is this the last unused code, or are more PRs waiting?

@GLEF1X
Copy link
Contributor Author

GLEF1X commented Jan 8, 2023

Hi @corona10! Thank you for the fast response! Yeah, I found more unused code; I'll keep committing to this pr.

@corona10
Copy link
Member

corona10 commented Jan 8, 2023

Hi @corona10! Thank you for the fast response! Yeah, I found more unused code; I'll keep committing to this pr.

Yes please, I would like to squash them in a single PR if possible.

@GLEF1X
Copy link
Contributor Author

GLEF1X commented Jan 8, 2023 •
edited
Loading

I think that's it. That's all that I could find related to unused code.

@corona10 corona10 merged commit d5349bb into psf:main Jan 10, 2023
@GLEF1X GLEF1X deleted the feature/obsolete-code branch March 31, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

@corona10 corona10 corona10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GLEF1X @corona10 @methane