Use urllib for chunked requests #5128
Conversation
|
fantastic. This was 100% my least favorite part of the codebase, and what I ended up doing in Requests III as well! |
|
Hi @nateprewitt , I understand that this PR was reverted for 2.23.0 release. You mentioned on the revert that there might be outstanding work. Do you see anything remaining for this particular PR? If this was referring to the open issues above (#3844 , #4402, #4894), I believe they are all closed by this PR. I personally run a test without/with the fix on my own test case and the fix worked fine (as commented on #3844). Please let me know if I can help Thanks! |
|
What exactly is the outstanding issue with this PR? By removing this from the master branch our dependent softawre build has incorporated a release missing this functionality. There was no notification to the PR author this happened... Did the reversion have "adequate review"? I'll have to revert to fixing to an outdated commit or track a new fork with this functional fix re-applied. |
|
Hi ! Same problem here :( I've been debugging for hours a proxy issue on "chunked" requests where the proxy does not work and asks for authentication (407 http error code). I had to fork this project to put back this feature because with urllib3, it works perfectly. Can we plan to put this back ? @nateprewitt Otherwise, we need to fix the old code because it's not working with authenticated proxies ... :( Thanks |
|
I've re-resubmitted this again (again) as This PR |
Resubmit of https://github.com/kennethreitz/requests/pull/4958 with up to date merge. Also addresses https://github.com/kennethreitz/requests/pull/4179.
Specifically, in my use case, chunked requests when a proxy is in use results in failure to evaluate the proxy configuration and the request being sent direct. It appears that urllib3 supports chunking as an option so this fork to lower level urllib3 code seems to no longer be required.