Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise InvalidUrl if host starts with '.' character. #5414

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Raise InvalidUrl if host starts with '.' character. #5414

merged 1 commit into from
Dec 29, 2021

Conversation

mondeja
Copy link
Contributor

@mondeja mondeja commented Apr 5, 2020 •
edited
Loading

Closes #5367

Attempting to get http://.example.com results in a UnicodeError but should be raise InvalidUrl as attempting to get http://*example.com.

I've added InvalidUrl tests for http://.example.com and http://*example.com.

ghost
ghost approved these changes Oct 6, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

matespinda01
matespinda01 approved these changes Mar 2, 2021
View reviewed changes
Copy link

@matespinda01 matespinda01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nateprewitt nateprewitt added this to the 2.27.0 milestone Sep 9, 2021
@nateprewitt nateprewitt changed the base branch from master to main December 28, 2021 21:24
@sigmavirus24 sigmavirus24 merged commit d096599 into psf:main Dec 29, 2021
@nateprewitt nateprewitt mentioned this pull request Dec 29, 2021
Merged
@mondeja mondeja deleted the 5367 branch December 29, 2021 07:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matespinda01 matespinda01 matespinda01 approved these changes

@nateprewitt nateprewitt nateprewitt approved these changes

@math280h math280h math280h approved these changes

@sigmavirus24 sigmavirus24 sigmavirus24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.27.0
Development

Successfully merging this pull request may close these issues.

Getting http://.example.com raises UnicodeError
5 participants
@mondeja @sigmavirus24 @math280h @nateprewitt @matespinda01