Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6565; Add documentation to certs.where. #6617

Closed
wants to merge 1 commit into from

Conversation

tanrbobanr
Copy link

Closes #6565 by adding documentation to certs.where. A wrapper was used so that the __doc__ attribute of certifi.where would be preserved, and to allow for greater intellisense coverage. The second issue brought up in #6565 could not be addressed, as the CA-certs default path is only taken from certs.where, and can be overridden on a per-instance level of Session instances (for example).

@sigmavirus24
Copy link
Contributor

This addresses only one sliver of that issue, not the core of what they're asking for.

@tanrbobanr
Copy link
Author

This addresses only one sliver of that issue, not the core of what they're asking for.

Yeah, this is my first PR so I'm kinda new to this. From what I was able to see, the cacerts_loaded function would not really be possible unless it was a method of Session, as (to my knowledge) the only way to change the bundle path is through verify (a Session argument) and through merge_environment_settings (a method of Session), meaning there would be no way to get this information globally (again, to my knowledge).

@tanrbobanr tanrbobanr closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA-certs bundles and requests.certs.where - Improved documentation
2 participants