Add a BoundPorts property to REstate gRPC Server #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 27, 2017 08:14
- Change REstateGrpcServer to set BoundPorts on Start, clear on shutdown - Change Remote tests to use automatic port assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
✨ Adds a BoundPorts property to the gRPC server, so that a user can discover the bound ports when using the
0flag for allocating a server on any unused port.💚 Also had to convert scenario tests to
asyncdue to deadlocks under weird thread unavailability scenarios.Alternate Designs
Why Should This Be In Core?
The flexibility is really nice for ad-hoc scenarios and tests.
Benefits
Using
0for port allows you to run multiple isolated REstate servers on a single machine. Can be load balanced at another layer if desired.Possible Drawbacks
Applicable Issues